Update tf resource to aws sdk group overrides #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbbush
force-pushed
the
tf-api-group-overrides
branch
from
9739431 to
0fe9d1c
Compare
mbbush
force-pushed
the
tf-api-group-overrides
branch
from
0fe9d1c to
9f27571
Compare
Signed-off-by: Matt Bush <[email protected]>
Signed-off-by: Matt Bush <[email protected]>
mbbush
force-pushed
the
tf-api-group-overrides
branch
from
9f27571 to
1e919bb
Compare
|
This provider repo does not have enough maintainers to address every pull request. Since there has been no activity in the last 90 days it is now marked as |
|
This pull request is being closed since there has been no activity for 14 days since marking it as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
I wrote a pair of scripts to
My motivation was while working on support for some new MSK resources, they ended up in api group
mskinstead ofkakfalike the other msk resources, because they weren't on theGroupMaplist.While working on getting the code to fully generate the GroupMap, I discovered what looked like several mistakes in the behavior of the previous
GroupMap. I added conditionals to preserve the existing behavior, because doing otherwise would have resulted in changing the kind or api group of the affected resources.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
It produces zero diff to the generated code.